feat: Adding "skill" server adapter in spec and engine#119
Open
feat: Adding "skill" server adapter in spec and engine#119
Conversation
Contributor
|
This is confusing ^^' We have a Notion specification page, a PR with the wiki specification with request fir change and a PR with an implentation fo the spec. I do not know against which specification I am supposed to use to validate this PR... Let us discuss process before moving on =) |
Contributor
Author
|
The wiki PR was created before the work on this implementation started, hence the disconnect. I will refresh it. For the scope of this PR, the included spec (agent-skills-support-proposal.md) is exactly the same as the spec in Notion that you reviewed. So this implementation is consistent with it. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Introduces the
skillserver adapter, which exposes one or more AI agent skill definitions over HTTP, making them discoverable and downloadable by agents and tooling.Spec layer:
ExposedSkillSpec— skill definition (name, description, tools, location, metadata, compatibility flags)SkillToolSpec/SkillToolFromSpec— tool declarations (derived from capability actions or standalone instructions)SkillServerSpec— groups skills under a shared base path and portServerSpecwired to acceptskilladapter typeEngine layer:
SkillServerAdapter— wires RestletRouter+Serverwith five routes and starts the HTTP listenerSkillServerResource(abstract) — shared base with path-traversal validation,MetadataService-based MIME detection, and a sharedObjectMapperSkillCatalogResource—GET /skillsSkillDetailResource—GET /skills/{name}SkillContentsResource—GET /skills/{name}/contentsSkillFileResource—GET /skills/{name}/files/{file}(streaming viaFileRepresentation)SkillDownloadResource—GET /skills/{name}/download(ZIP viaOutputRepresentation)All JSON responses use
JacksonRepresentation<ObjectNode>(no in-memory string serialization).Schema:
ExposesSkill,ExposedSkill,SkillTooladded tocapability-schema.json.Docs: §§3.5.9–3.5.12 added to
naftiko-specification-v0.5.md;skill-adapter.ymlexample added.Tests: 27 new tests across
CapabilitySkillIntegrationTest,SkillServerSpecRoundTripTest, andSkillToolSpecDeserializationTest.